Hi,
On Fri, Feb 15, 2013 at 7:14 AM, Guennadi Liakhovetski <[email protected]> wrote: > Many MMC capability flags are platform-dependent and are traditionally set > in platform data. With DT often each such capability requires a special > binding. Add bindings for MMC_CAP_SD_HIGHSPEED, MMC_CAP_MMC_HIGHSPEED, > MMC_CAP_POWER_OFF_CARD and MMC_CAP_SDIO_IRQ capabilities. Also add code to > DT parser to look up "keep-power-in-suspend" and "enable-sdio-wakeup" > bindings and set MMC_PM_KEEP_POWER and MMC_PM_WAKE_SDIO_IRQ respectively, > if found. > > Signed-off-by: Guennadi Liakhovetski <[email protected]> I just came across this patch after it was merged (with no review from any device tree maintainer :() > --- > Documentation/devicetree/bindings/mmc/mmc.txt | 4 ++++ > drivers/mmc/core/host.c | 13 +++++++++++++ > 2 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt > b/Documentation/devicetree/bindings/mmc/mmc.txt > index 24c8552..d9ab51f 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/mmc.txt > @@ -25,6 +25,10 @@ Optional properties: > - max-frequency: maximum operating clock frequency > - no-1-8-v: when present, denotes that 1.8v card voltage is not supported on > this system, even if the controller claims it is. > +- cap-sd-highspeed: SD high-speed timing is supported > +- cap-mmc-highspeed: MMC high-speed timing is supported > +- cap-power-off-card: powering off the card is safe > +- cap-sdio-irq: enable SDIO IRQ signalling on this interface These are bad names for describing hardware properties. There is no reason to carry over the "cap" prefix from the internal usage of the hardware characteristics in the kernel. Other drivers use, for example "supports-highspeed", which this duplicates to some extent. More work should have been done to commonalize them. Etc. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
