Op 28-07-10 17:41, Mark Brown schreef: > On 28 Jul 2010, at 07:48, Maurus Cuelenaere <[email protected]> wrote: >>> + struct sdhci_s3c *sc = sdhci_priv(host); >>> + >>> + if (sc->vmmc) { >>> + int ret = regulator_disable(sc->vmmc); >>> + if (ret) >>> + return ret; >>> + mdelay(2); >> Shouldn't these delays be handled in the regulator framework itself? > A 2ms delay on power down seems suspicious for a regulator. I'm not sure why > this is required but if it is I suspect it's due to a large cap on the > regulator output and light load rather than something that's always true for > whatever regulator is providing the supply.
I wasn't suggesting to do the delay in the framework *itself*, rather in the regulator driver and/or the board platform code which needs this delay. -- Maurus Cuelenaere -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
