On Wed, 30 Sep 2009 17:22:14 +0530 Mahadev Cholachagudda <[email protected]> wrote:
>
> Let me know if you have any comments/suggestions?
>
I have a few:
1. The obvious one; why? When does user space need to know the speed
rating, and is the speed rating still meaningful after all the layers
in the kernel? Userspace ABI stuff should be added with great care.
2. I think it's better to not show the attribute when it isn't relevant
rather than return 0xFF.
3. Isn't this a SD 2.0 feature? So you should check the version of the
card before populating/showing this field.
Rgds
--
-- Pierre Ossman
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
signature.asc
Description: PGP signature
