On 07/07/2016 12:59 AM, Steve Longerbeam wrote:
> Add a device tree boolean property "bt656-4" to allow setting
> the ITU-R BT.656-4 compatible bit.
>
> Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com>
Hi,
Thanks for the patch.
> ---
> drivers/media/i2c/adv7180.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> index 92e2f37..fff887c 100644
> --- a/drivers/media/i2c/adv7180.c
> +++ b/drivers/media/i2c/adv7180.c
> @@ -58,7 +58,7 @@
>
> #define ADV7180_REG_OUTPUT_CONTROL 0x0003
> #define ADV7180_REG_EXTENDED_OUTPUT_CONTROL 0x0004
> -#define ADV7180_EXTENDED_OUTPUT_CONTROL_NTSCDIS 0xC5
> +#define ADV7180_EXTENDED_OUTPUT_CONTROL_BT656_4 0x80
>
> #define ADV7180_REG_AUTODETECT_ENABLE 0x0007
> #define ADV7180_AUTODETECT_DEFAULT 0x7f
> @@ -216,6 +216,7 @@ struct adv7180_state {
> struct gpio_desc *pwdn_gpio;
> v4l2_std_id curr_norm;
> bool autodetect;
> + bool bt656_4; /* use bt.656-4 standard for NTSC */
> bool powered;
> u8 input;
>
> @@ -1281,6 +1282,17 @@ static int init_device(struct adv7180_state *state)
> if (ret)
> goto out_unlock;
>
> + if (state->bt656_4) {
> + ret = adv7180_read(state, ADV7180_REG_EXTENDED_OUTPUT_CONTROL);
> + if (ret < 0)
> + goto out_unlock;
> + ret |= ADV7180_EXTENDED_OUTPUT_CONTROL_BT656_4;
> + ret = adv7180_write(state, ADV7180_REG_EXTENDED_OUTPUT_CONTROL,
> + ret);
> + if (ret < 0)
> + goto out_unlock;
> + }
> +
> ret = adv7180_program_std(state);
> if (ret)
> goto out_unlock;
> @@ -1332,6 +1344,10 @@ static int adv7180_of_parse(struct adv7180_state
> *state)
> return PTR_ERR(state->pwdn_gpio);
> }
>
> + /* select ITU-R BT.656-4 compatible? */
> + if (of_property_read_bool(client->dev.of_node, "bt656-4"))
> + state->bt656_4 = true;
This property needs to be documented. In my opinion it should also be a
property of the endpoint sub-node rather than the toplevel device node since
this is a configuration of the endpoint format.
> +
> return 0;
> }
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
