On 10/05/2015 03:24 PM, Olli Salonen wrote:
Hi Laura,While the patch itself does what it says, the return code for the si2157_init will be 0 even if there's a faulty firmware file. Wouldn't it be better to set the return code as -EINVAL like done a few lines earlier in the code (see below)? if (fw->size % 17 != 0) { dev_err(&client->dev, "firmware file '%s' is invalid\n", fw_name); ret = -EINVAL; goto err_release_firmware; } Cheers, -olli
Right, I'll update with v2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
