On 08/23/2015 10:17 PM, Mauro Carvalho Chehab wrote:
> This code is not used in practice. Get rid of it before
> start converting links to lists.

I assume the reason is that links are always created *after*
entities are registered?

Can you add that to this commit log?

With that change:

Acked-by: Hans Verkuil <hans.verk...@cisco.com>

> 
> Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com>
> 
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
> index 138b18416460..0d85c6c28004 100644
> --- a/drivers/media/media-device.c
> +++ b/drivers/media/media-device.c
> @@ -443,13 +443,6 @@ int __must_check media_device_register_entity(struct 
> media_device *mdev,
>       media_gobj_init(mdev, MEDIA_GRAPH_ENTITY, &entity->graph_obj);
>       list_add_tail(&entity->list, &mdev->entities);
>  
> -     /*
> -      * Initialize objects at the links
> -      * in the case where links got created before entity register
> -      */
> -     for (i = 0; i < entity->num_links; i++)
> -             media_gobj_init(mdev, MEDIA_GRAPH_LINK,
> -                             &entity->links[i].graph_obj);
>       /* Initialize objects at the pads */
>       for (i = 0; i < entity->num_pads; i++)
>               media_gobj_init(mdev, MEDIA_GRAPH_PAD,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to