Hi William,

On Wed, 20 May 2015, William Towle wrote:

> Pretty print fourcc and code in format debugging statements.
> 
> Signed-off-by: Rob Taylor <rob.tay...@codethink.co.uk>
> Reviewed-by: William Towle <william.to...@codethink.co.uk>
> ---
>  drivers/media/platform/soc_camera/rcar_vin.c |   22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c 
> b/drivers/media/platform/soc_camera/rcar_vin.c
> index b530503..0bebca5 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c

[snip]

> @@ -1720,11 +1725,14 @@ static int rcar_vin_try_fmt(struct soc_camera_device 
> *icd,
>       int width, height;
>       int ret;
>  
> +     dev_dbg(icd->parent, "TRY_FMT(%c%c%c%c, %ux%u)\n",
> +             pixfmtstr(pix->pixelformat), pix->width, pix->height);
> +

Why is this additional debugging needed? Doesn't an identical call in 
soc_camera_try_fmt() already print the same information just before 
calling rcar_vin_try_fmt()?

Thanks
Guennadi
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to