----- Original Message ----- > From: "Mauro Carvalho Chehab" <mche...@osg.samsung.com> > To: "Linux Media Mailing List" <linux-media@vger.kernel.org> > Cc: "Mauro Carvalho Chehab" <mche...@osg.samsung.com>, "Mauro Carvalho > Chehab" <mche...@infradead.org>, "Lars-Peter > Clausen" <l...@metafoo.de>, "Michael Buesch" <m...@bues.ch>, "Antti > Palosaari" <cr...@iki.fi>, "Hans Verkuil" > <hverk...@xs4all.nl>, "Sakari Ailus" <sakari.ai...@linux.intel.com>, "Ondrej > Zary" <li...@rainbow-software.org>, > "Ramakrishnan Muthukrishnan" <ramak...@cisco.com>, "Laurent Pinchart" > <laurent.pinch...@ideasonboard.com>, "Takashi > Iwai" <ti...@suse.de>, "Amber Thrall" <amber.rose.thr...@gmail.com>, > "Federico Simoncelli" <fsimo...@redhat.com>, > "James Harper" <james.har...@ejbdigital.com.au>, "Dan Carpenter" > <dan.carpen...@oracle.com>, "Konrad Rzeszutek Wilk" > <konrad.w...@oracle.com> > Sent: Tuesday, May 19, 2015 1:00:57 PM > Subject: [PATCH 2/2] drivers: Simplify the return code > > If the last thing we do in a function is to call another > function and then return its value, we don't need to store > the returned code into some ancillary var. > > Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com> > > diff --git a/drivers/media/dvb-frontends/lgs8gxx.c > b/drivers/media/dvb-frontends/lgs8gxx.c > index 3c92f36ea5c7..9b0166cdc7c2 100644 > --- a/drivers/media/dvb-frontends/lgs8gxx.c > +++ b/drivers/media/dvb-frontends/lgs8gxx.c > @@ -544,11 +544,7 @@ static int lgs8gxx_set_mpeg_mode(struct lgs8gxx_state > *priv, > t |= clk_pol ? TS_CLK_INVERTED : TS_CLK_NORMAL; > t |= clk_gated ? TS_CLK_GATED : TS_CLK_FREERUN; > > - ret = lgs8gxx_write_reg(priv, reg_addr, t); > - if (ret != 0) > - return ret; > - > - return 0; > + return lgs8gxx_write_reg(priv, reg_addr, t); > }
Personally I prefer the current style because it's more consistent with all the other calls in the same function (return ret when ret != 0). It also allows you to easily add/remove calls without having to deal with the last special case return my_last_fun_call(...). Anyway it's not a big deal, I think it's your call. -- Federico -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
