Are these even cases you should use BUG()? How about WARN()...

Antti

On 09/25/2014 01:27 AM, Mauro Carvalho Chehab wrote:
As reported by smatch:

drivers/media/pci/cx88/cx88-video.c:699 get_queue() info: ignoring unreachable 
code.
drivers/media/pci/cx88/cx88-video.c:714 get_resource() info: ignoring 
unreachable code.
drivers/media/pci/cx88/cx88-video.c:815 video_read() info: ignoring unreachable 
code.

Signed-off-by: Mauro Carvalho Chehab <mche...@osg.samsung.com>

diff --git a/drivers/media/pci/cx88/cx88-video.c 
b/drivers/media/pci/cx88/cx88-video.c
index ed8cb9037b6f..ce27e6d4f16e 100644
--- a/drivers/media/pci/cx88/cx88-video.c
+++ b/drivers/media/pci/cx88/cx88-video.c
@@ -696,7 +696,6 @@ static struct videobuf_queue *get_queue(struct file *file)
                return &fh->vbiq;
        default:
                BUG();
-               return NULL;
        }
  }

@@ -711,7 +710,6 @@ static int get_resource(struct file *file)
                return RESOURCE_VBI;
        default:
                BUG();
-               return 0;
        }
  }

@@ -812,7 +810,6 @@ video_read(struct file *file, char __user *data, size_t 
count, loff_t *ppos)
                                            file->f_flags & O_NONBLOCK);
        default:
                BUG();
-               return 0;
        }
  }



--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to