Hi Ondrej,
On 06/03/2013 10:46 AM, Hans Verkuil wrote:
> On Tue May 14 2013 22:54:45 Ondrej Zary wrote:
>> Remove tea575x-specific code from bttv and use the common driver instead.
>>
>> Signed-off-by: Ondrej Zary <li...@rainbow-software.org>
>> ---
>> drivers/media/pci/bt8xx/bttv-cards.c | 317
>> ++++++++++++---------------------
>> drivers/media/pci/bt8xx/bttv-driver.c | 6 +-
>> drivers/media/pci/bt8xx/bttvp.h | 14 +-
>> sound/pci/Kconfig | 4 +-
>> 4 files changed, 124 insertions(+), 217 deletions(-)
>>
>
> ...
>
>> diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
>> index fe6fa93..83e0df5 100644
>> --- a/sound/pci/Kconfig
>> +++ b/sound/pci/Kconfig
>> @@ -2,8 +2,8 @@
>>
>> config SND_TEA575X
>> tristate
>> - depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
>> || RADIO_MAXIRADIO || RADIO_SHARK
>> - default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 || RADIO_MAXIRADIO ||
>> RADIO_SHARK
>> + depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
>> || RADIO_MAXIRADIO || RADIO_SHARK || VIDEO_BT848
>> + default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2 || RADIO_MAXIRADIO ||
>> RADIO_SHARK || VIDEO_BT848
>>
>> menuconfig SND_PCI
>> bool "PCI sound devices"
>>
>
> In addition, bttv should also become dependent on SND.
>
> Frankly, isn't it time that tea575x-tuner moves to drivers/media/common or
> driver/media/radio? It's really weird to have such a fairly widely used v4l
> module in sound.
It makes more sense to add this patch to the patch series moving tea575x to
drivers/media.
It simplifies the Kconfig handling substantially.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
