From: Hans Verkuil <hans.verk...@cisco.com>

The s_input implementation allowed input 1 even if that didn't exist.

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>
---
 drivers/media/pci/cx25821/cx25821-video.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/pci/cx25821/cx25821-video.c 
b/drivers/media/pci/cx25821/cx25821-video.c
index a9aa096..9ddc7ac 100644
--- a/drivers/media/pci/cx25821/cx25821-video.c
+++ b/drivers/media/pci/cx25821/cx25821-video.c
@@ -1163,10 +1163,8 @@ int cx25821_vidioc_s_input(struct file *file, void 
*priv, unsigned int i)
                        return err;
        }
 
-       if (i >= CX25821_NR_INPUT) {
-               dprintk(1, "%s(): -EINVAL\n", __func__);
+       if (i >= CX25821_NR_INPUT || INPUT(i)->type == 0)
                return -EINVAL;
-       }
 
        mutex_lock(&dev->lock);
        cx25821_video_mux(dev, i);
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to