On Sun March 24 2013 15:27:23 Mauro Carvalho Chehab wrote:
> Em Mon, 18 Mar 2013 13:32:00 +0100
> Hans Verkuil <hverk...@xs4all.nl> escreveu:
> 
> > From: Hans Verkuil <hans.verk...@cisco.com>
> > 
> > Synced to commit e9815ac5503ae60cfbf6ff8037035de8f62e2846 from
> > branch next in git repository https://github.com/bluecherrydvr/solo6x10.git
> > 
> > Only removed some code under #if LINUX_VERSION_CODE < some-kernel-version,
> > renamed the driver back to solo6x10 from solo6x10-edge and removed the
> > unnecessary compat.h header.
> > 
> > Otherwise the code is identical.
> > 
> 
> ...
> 
> > @@ -21,29 +26,78 @@
> >  #include <linux/module.h>
> >  #include <linux/pci.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/slab.h>
> 
> You can't remove slab.h if any k*alloc function is used, or it will
> break compilation, depending on the Kconfig options selected.

Well spotted, thanks!

> 
> The same type of removal are on other files inside this patch.
> 
> Please fix.

Done. New pull request posted.

Regards,

        Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to