On 02/04/2013 12:40 AM, Jose Alberto Reguero wrote:
This patch move the loop_thru configuration to the attach function,
because with dual tuners until loop_tru configuration the other tuner
don't work.

Signed-off-by: Jose Alberto Reguero <jaregu...@telefonica.net>

Reviewed-by: Antti Palosaari <cr...@iki.fi>



diff -upr linux/drivers/media/tuners/mxl5007t.c 
linux.new/drivers/media/tuners/mxl5007t.c
--- linux/drivers/media/tuners/mxl5007t.c       2013-02-03 23:16:08.031628907 
+0100
+++ linux.new/drivers/media/tuners/mxl5007t.c   2013-02-03 23:14:12.196089297 
+0100
@@ -374,7 +374,6 @@ static struct reg_pair_t *mxl5007t_calc_
        mxl5007t_set_if_freq_bits(state, cfg->if_freq_hz, cfg->invert_if);
        mxl5007t_set_xtal_freq_bits(state, cfg->xtal_freq_hz);

-       set_reg_bits(state->tab_init, 0x04, 0x01, cfg->loop_thru_enable);
        set_reg_bits(state->tab_init, 0x03, 0x08, cfg->clk_out_enable << 3);
        set_reg_bits(state->tab_init, 0x03, 0x07, cfg->clk_out_amp);

@@ -908,6 +907,18 @@ struct dvb_frontend *mxl5007t_attach(str
        if (mxl_fail(ret))
                goto fail;

+       if (fe->ops.i2c_gate_ctrl)
+               fe->ops.i2c_gate_ctrl(fe, 1);
+
+       ret = mxl5007t_write_reg(state, 0x04,
+               state->config->loop_thru_enable);
+
+       if (fe->ops.i2c_gate_ctrl)
+               fe->ops.i2c_gate_ctrl(fe, 0);
+
+       if (mxl_fail(ret))
+               goto fail;
+
        fe->tuner_priv = state;

        mutex_unlock(&mxl5007t_list_mutex);


Looks good for my eyes!

Is clock output is enabled by default?

Are these two patches enough in order to get it working?

regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to