Hi Sylwester,

On 04.12.2012 16:55, Sylwester Nawrocki wrote:
Hi Andrzej,

On 11/23/2012 04:22 PM, Andrzej Hajda wrote:
Function support variable number of subdevs in pipe-line.
I'm will be applying this patch with description changed to:

Make the pipeline try format routine more generic to support any
number of subdevs in the pipeline, rather than hard coding it for
only a sensor, MIPI-CSIS and FIMC subdevs and the FIMC video node.
Seems better :)

Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com>
---
  drivers/media/platform/s5p-fimc/fimc-capture.c |  100 +++++++++++++++---------
  1 file changed, 64 insertions(+), 36 deletions(-)

...
  /**
   * fimc_pipeline_try_format - negotiate and/or set formats at pipeline
   *                            elements
@@ -809,65 +824,78 @@ static int fimc_pipeline_try_format(struct fimc_ctx *ctx,
...
                ffmt = fimc_find_format(NULL, mf->code != 0 ? &mf->code : NULL,
                                        FMT_FLAGS_CAM, i++);
-               if (ffmt == NULL) {
-                       /*
-                        * Notify user-space if common pixel code for
-                        * host and sensor does not exist.
-                        */
+               if (ffmt == NULL)
                        return -EINVAL;
-               }
+
And as we agreed, with this chunk removed from the patch. Since the comment
still stands.
OK.

--

Thank you!
Sylwester


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to