Hi Sylwester,

On Tuesday 27 November 2012 23:54:40 Sylwester Nawrocki wrote:
> On 11/25/2012 01:41 AM, Laurent Pinchart wrote:
> > When subdev registration fails the subdev v4l2_dev field is left to a
> > non-NULL value. Later calls to v4l2_device_unregister_subdev() will
> > consider the subdev as registered and will module_put() the subdev
> > module without any matching module_get().
> > 
> > Fix this by setting the subdev v4l2_dev field to NULL in
> > v4l2_device_register_subdev() when the function fails.
> > 
> > Signed-off-by: Laurent Pinchart<laurent.pinch...@ideasonboard.com>
> 
> Acked-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Thank you.

> I'm just wondering whether including this patch in stable kernel releases
> could potentially break anything.

I don't think it would, the patch only touches error paths, and clearly fixes 
a bug. So

Cc: sta...@vger.kernel.org

looks like a good idea.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to