On Tue, 27 Nov 2012, Albert Wang wrote: [snip]
> >you did change a couple of things - like replaced printk() with cam_err(), > >and actually > >here: > > > >> + cam_err(cam, "marvell-cam: Cafe can't do S/G I/O," \ > >> + "attempting vmalloc mode instead\n"); > > > >and here > > > >> + cam_warn(cam, "Unable to alloc DMA buffers at load" \ > >> + "will try again later\n"); > > > >the backslashes are not needed... Also in these declarations: > > > Sorry, I have to clarify it. :) > I replaced printk() and add backslashes just because the tool > scripts/checkpatch.pl. > It will report error when remove the blackslash and report warning when using > printk(). > But these errors and warnings will be reported only in latest kernel code. :) > > If you think we can ignore these errors and warnings, I'm OK to get back to > the original code. :) Replacing printk() with cam_*() is ok, just please remove the backslashes. Actually, there are also spaces missing in above strings - when they'll be pasted together. As for checkpatch, I would ignore this its warning, because this is not new code, this has been there also in the original driver, you're just moving the code around. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
