On Tue, Sep 18, 2012 at 05:14:31PM +0530, Shubhrajyoti D wrote: > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future.
no need for these tabs here.
FWIW:
Reviewed-by: Felipe Balbi <ba...@ti.com>
>
> Signed-off-by: Shubhrajyoti D <shubhrajy...@ti.com>
> ---
> drivers/media/radio/saa7706h.c | 15 +++++++++++++--
> 1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/radio/saa7706h.c b/drivers/media/radio/saa7706h.c
> index bb953ef..54db36c 100644
> --- a/drivers/media/radio/saa7706h.c
> +++ b/drivers/media/radio/saa7706h.c
> @@ -199,8 +199,19 @@ static int saa7706h_get_reg16(struct v4l2_subdev *sd,
> u16 reg)
> u8 buf[2];
> int err;
> u8 regaddr[] = {reg >> 8, reg};
> - struct i2c_msg msg[] = { {client->addr, 0, sizeof(regaddr), regaddr},
> - {client->addr, I2C_M_RD, sizeof(buf), buf} };
> + struct i2c_msg msg[] = {
> + {
> + .addr = client->addr,
> + .len = sizeof(regaddr),
> + .buf = regaddr
> + },
> + {
> + .addr = client->addr,
> + .flags = I2C_M_RD,
> + .len = sizeof(buf),
> + .buf = buf
> + }
> + };
>
> err = saa7706h_i2c_transfer(client, msg, ARRAY_SIZE(msg));
> if (err)
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
balbi
signature.asc
Description: Digital signature
