On Mon September 17 2012 17:36:36 Jonathan Corbet wrote:
> On Mon, 17 Sep 2012 16:10:43 +0200
> Hans Verkuil <hverk...@xs4all.nl> wrote:
>
> > Why WARN_ON_ONCE? I'd want to see this all the time, not just once.
> >
> > It's certainly better than BUG_ON, but I'd go for WARN_ON.
>
> I like WARN_ON_ONCE better, myself. Avoids the risk of spamming the logs,
> and once is enough to answer that "why doesn't my camera work?" question.
> Don't feel all that strongly about it, though...
However, videobuf2-core.c is a core function of a core module. So it will
give this warning once for one driver, then another is loaded with the same
problem and you'll get no warnings anymore. It makes sense in a driver, but
not here IMHO. Unless I'm missing something.
Neither is this likely to ever spam the logs. It's called only when the device
is initialized.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
