Hi Sakari, On Tuesday 24 April 2012 01:23:06 Sakari Ailus wrote: > Hi Laurent, > > The patch looks good as such on the first glance, but I have another > question: why are you not using the selections API instead? It's in > Mauro's tree already.
You're totally right, we need to convert the selection API. The reason why I've implemented crop support at the CCDC output was simply that I needed it for a project and didn't have time to implement the selection API. As the code works, I considered it would be good to have it upstream until we switch to the selection API. > Also, the old S_CROP IOCTL only has been defined for sink pads, not source. We're already using crop on source pads on sensors ;-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
