Hi Tomasz, On Friday 26 August 2011 15:06:06 Tomasz Stanislawski wrote: > This patch fix the handling of data passed to V4L2 ioctls. The content of > the structures is not copied if the ioctl fails. It blocks ability to > obtain any information about occurred error other then errno code. This > patch fix this issue.
Does the V4L2 spec say anything on this topic ? We might have applications that rely on the ioctl argument structure not being touched when a failure occurs. > Signed-off-by: Tomasz Stanislawski <t.stanisl...@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > --- > drivers/media/video/v4l2-ioctl.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/v4l2-ioctl.c > b/drivers/media/video/v4l2-ioctl.c index 543405b..9f54114 100644 > --- a/drivers/media/video/v4l2-ioctl.c > +++ b/drivers/media/video/v4l2-ioctl.c > @@ -2490,8 +2490,6 @@ video_usercopy(struct file *file, unsigned int cmd, > unsigned long arg, err = -EFAULT; > goto out_array_args; > } > - if (err < 0) > - goto out; > > out_array_args: > /* Copy results into user buffer */ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
