On 13.07.2011 23:28, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued at the > http://git.linuxtv.org/media_tree.git tree: > > Subject: [media] DVB: dvb_frontend: off by one in dtv_property_dump() > Author: Dan Carpenter <erro...@gmail.com> > Date: Thu May 26 05:44:52 2011 -0300 > > If the tvp->cmd == DTV_MAX_COMMAND then we read past the end of the > array.
That's wrong, because the array size is DTV_MAX_COMMAND + 1. Using the ARRAY_SIZE macro instead might reduce the confusion. Regards, Andreas > Signed-off-by: Dan Carpenter <erro...@gmail.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@redhat.com> > > drivers/media/dvb/dvb-core/dvb_frontend.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > --- > > http://git.linuxtv.org/media_tree.git?a=commitdiff;h=a3e4adf274f86b2363fedaa964297cb38526cef0 > > diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c > b/drivers/media/dvb/dvb-core/dvb_frontend.c > index bed7bfe..c9c3c79 100644 > --- a/drivers/media/dvb/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb/dvb-core/dvb_frontend.c > @@ -982,7 +982,7 @@ static void dtv_property_dump(struct dtv_property *tvp) > { > int i; > > - if (tvp->cmd <= 0 || tvp->cmd > DTV_MAX_COMMAND) { > + if (tvp->cmd <= 0 || tvp->cmd >= DTV_MAX_COMMAND) { > printk(KERN_WARNING "%s: tvp.cmd = 0x%08x undefined\n", > __func__, tvp->cmd); > return; > > _______________________________________________ > linuxtv-commits mailing list > linuxtv-comm...@linuxtv.org > http://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
