> -----Original Message----- > From: Taneja, Archit > Sent: Monday, June 13, 2011 10:17 AM > To: Hiremath, Vaibhav > Cc: linux-media@vger.kernel.org > Subject: Re: [PATCH 2/2] OMAP_VOUT: Create separate file for VRFB related > API's > > Hi Vaibhav, > > On Friday 27 May 2011 12:31 PM, Taneja, Archit wrote: > > Introduce omap_vout_vrfb.c and omap_vout_vrfb.h, for all VRFB related > API's, > > making OMAP_VOUT driver independent from VRFB. This is required for > OMAP4 DSS, > > since OMAP4 doesn't have VRFB block. > > > > Added new enum vout_rotation_type and "rotation_type" member to > omapvideo_info, > > this is initialized based on the arch type in omap_vout_probe. The > rotation_type > > var is now used to choose between vrfb and non-vrfb calls. > > Any comments on this patch? > Archit,
Last week I had to park this due to some high priority issue, today I am going to validate these patches and will respond you. Code implementation point of view, this patch looks ok. And I believe you will incorporate my comments on first patch. Thanks, Vaibhav > <snip> > > Thanks, > Archit -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
