Em 19-05-2011 07:41, Sakari Ailus escreveu: > This patch adds the driver for the adp1653 LED flash controller. This > controller supports a high power led in flash and torch modes and an > indicator light, sometimes also called privacy light. > > The adp1653 is used on the Nokia N900. > > Signed-off-by: Sakari Ailus <sakari.ai...@maxwell.research.nokia.com> > Signed-off-by: Tuukka Toivonen <tuukka...@gmail.com> > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: David Cohen <daco...@gmail.com> > --- > drivers/media/video/Kconfig | 7 + > drivers/media/video/Makefile | 2 + > drivers/media/video/adp1653.c | 481 > +++++++++++++++++++++++++++++++++++++++++ > include/media/adp1653.h | 126 +++++++++++ > 4 files changed, 616 insertions(+), 0 deletions(-) > create mode 100644 drivers/media/video/adp1653.c > create mode 100644 include/media/adp1653.h > > diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig > index 00f51dd..c004dbb 100644 > --- a/drivers/media/video/Kconfig > +++ b/drivers/media/video/Kconfig > @@ -344,6 +344,13 @@ config VIDEO_TCM825X > This is a driver for the Toshiba TCM825x VGA camera sensor. > It is used for example in Nokia N800. > > +config VIDEO_ADP1653 > + tristate "ADP1653 flash support" > + depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER > + ---help--- > + This is a driver for the ADP1653 flash controller. It is used for > + example in Nokia N900. > + > config VIDEO_SAA7110 > tristate "Philips SAA7110 video decoder" > depends on VIDEO_V4L2 && I2C
The patches look sane. I have just one comment: Please, create a separate section for the LED controls. OK, some patches already messed the Kconfig stuff by mixing sensors together with video decoders, but let's not make the things worse. Thanks, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
