Hi Felipe, On Monday 14 February 2011 13:37:39 Felipe Balbi wrote: > On Mon, Feb 14, 2011 at 01:21:34PM +0100, Laurent Pinchart wrote: > > The OMAP3 ISP CCP2 and CSI2 receivers provide an interface to connect > > serial MIPI sensors to the device. > > > > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > Signed-off-by: Sakari Ailus <sakari.ai...@iki.fi> > > Signed-off-by: David Cohen <daco...@gmail.com> > > Signed-off-by: Stanimir Varbanov <svarba...@mm-sol.com> > > Signed-off-by: Vimarsh Zutshi <vimarsh.zut...@gmail.com> > > Signed-off-by: Tuukka Toivonen <tuukka...@gmail.com> > > Signed-off-by: Sergio Aguirre <saagui...@ti.com> > > Signed-off-by: Antti Koskipaa <akosk...@gmail.com> > > Signed-off-by: Ivan T. Ivanov <iiva...@mm-sol.com> > > Signed-off-by: RaniSuneela <r...@ti.com> > > Signed-off-by: Atanas Filipov <afili...@mm-sol.com> > > Signed-off-by: Gjorgji Rosikopulos <grosikopu...@mm-sol.com> > > Signed-off-by: Hiroshi DOYU <hiroshi.d...@nokia.com> > > Signed-off-by: Nayden Kanchev <nkanc...@mm-sol.com> > > Signed-off-by: Phil Carmody <ext-phil.2.carm...@nokia.com> > > Signed-off-by: Artem Bityutskiy <artem.bityuts...@nokia.com> > > Signed-off-by: Dominic Curran <dcur...@ti.com> > > Signed-off-by: Ilkka Myllyperkio <ilkka.myllyper...@sofica.fi> > > Signed-off-by: Pallavi Kulkarni <p-kulka...@ti.com> > > Signed-off-by: Vaibhav Hiremath <hvaib...@ti.com> > > checkpatch still complains a bit about this one: > > CHECK: struct mutex definition without comment > #1368: FILE: drivers/media/video/omap3-isp/ispqueue.h:157: > + struct mutex lock; > > CHECK: spinlock_t definition without comment > #1369: FILE: drivers/media/video/omap3-isp/ispqueue.h:158: > + spinlock_t irqlock;
Those two have a kerneldoc comment in front of the structure definition. > WARNING: please, no space before tabs > #2723: FILE: drivers/media/video/omap3-isp/ispvideo.h:49: > + * ^Ibits. Identical to @code if the format is 10 bits wide or less.$ > > WARNING: please, no space before tabs > #2725: FILE: drivers/media/video/omap3-isp/ispvideo.h:51: > + * ^Iformat. Identical to @code if the format is not DPCM compressed.$ > > CHECK: spinlock_t definition without comment > #2762: FILE: drivers/media/video/omap3-isp/ispvideo.h:88: > + spinlock_t lock; > > CHECK: struct mutex definition without comment > #2823: FILE: drivers/media/video/omap3-isp/ispvideo.h:149: > + struct mutex mutex; > > CHECK: struct mutex definition without comment > #2840: FILE: drivers/media/video/omap3-isp/ispvideo.h:166: > + struct mutex stream_lock; > > total: 0 errors, 2 warnings, 5 checks, 2806 lines checked > > /home/balbi/tst.diff has style problems, please review. If any of these > errors are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > does it make sense to fix those ? -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
