Hi Mauro,

Can you apply this patch to the media_build tree? It quotes the *.[ch] file
pattern used by find.

When I was experimenting with the media_build tree and trying
'make tar DIR=<git repo>' I kept ending up with just one source in my tar
archive. I couldn't for the life of me understand what was going on until
I realized that I had a copy of a media driver source in the top dir of my
git repository. Because the file pattern was not quoted it would expand to
that particular source and match only that one.

It took me a surprisingly long time before I figured this out :-(

Quoting the pattern fixes this.

Regards,

        Hans

Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

diff --git a/linux/Makefile b/linux/Makefile
index 8bbeee8..d731f61 100644
--- a/linux/Makefile
+++ b/linux/Makefile
@@ -58,7 +58,7 @@ todaytar:
        tar rvf $(PWD)/linux-media.tar git_log
        for i in $(TARDIR); do \
                if [ "`echo $$i|grep Documentation`" = "" ]; then \
-                       dir="`(cd $(DIR); find $$i -type f -name *.[ch])`"; \
+                       dir="`(cd $(DIR); find $$i -type f -name '*.[ch]')`"; \
                        dir="$$dir `(cd $(DIR); find $$i -type f -name 
Makefile)`"; \
                        dir="$$dir `(cd $(DIR); find $$i -type f -name 
Kconfig)`"; \
                        tar rvf $(PWD)/$(TODAY_TAR) -C $(DIR) $$dir; \
@@ -75,7 +75,7 @@ tar:
        tar rvf $(PWD)/linux-media.tar git_log
        for i in $(TARDIR); do \
                if [ "`echo $$i|grep Documentation`" = "" ]; then \
-                       dir="`(cd $(DIR); find $$i -type f -name *.[ch])`"; \
+                       dir="`(cd $(DIR); find $$i -type f -name '*.[ch]')`"; \
                        dir="$$dir `(cd $(DIR); find $$i -type f -name 
Makefile)`"; \
                        dir="$$dir `(cd $(DIR); find $$i -type f -name 
Kconfig)`"; \
                        tar rvf $(PWD)/linux-media.tar -C $(DIR) $$dir; \
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to