Hello. And thanks for the comments.
On Wed, 2010-09-08 at 20:35 +0200, ext Mauro Carvalho > > } > > @@ -386,6 +394,8 @@ const char *v4l2_ctrl_get_name(u32 id) > > case V4L2_CID_TUNE_PREEMPHASIS: return "Pre-emphasis settings"; > > case V4L2_CID_TUNE_POWER_LEVEL: return "Tune Power Level"; > > case V4L2_CID_TUNE_ANTENNA_CAPACITOR: return "Tune Antenna Capacitor"; > > + case V4L2_CID_FM_RX_CLASS: return "FM Radio Tuner > > Controls"; > > > + case V4L2_CID_FM_BAND: return "FM Band"; > > > There's no need for a FM control, as there's already an ioctl pair that > allows get/set the frequency > bandwidth: VIDIOC_S_TUNER and VIDIOC_G_TUNER. So, the entire patch here seems > uneeded/unwanted. Sometime ago Hans said the following in his comment to v5 patches: > Based on this article: > http://en.wikipedia.org/wiki/FM_broadcasting, there > seem to be only three bands for FM radio in > practice: 87.5-108, 76-90 (Japan) > and 65-74 (former Soviet republics, some former > eastern bloc countries). > > So this should be a standard control. Since the > latter band is being phased > out I think a menu control with just the two other > bands is sufficient. > > And I also think this should be a control of a new > FM_RX class. > > I know, that's not what I said last time. So sue > me :-) But if we now have a consensus when we are at v9 that's good news... Thanks, Matti -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
