On 2010-09-06 오후 3:53, Marek Szyprowski wrote:
In case of error during probe() the driver calls free_irq() function
on not yet allocated irq. This patches fixes the call sequence in case of
the error.


I sent this fix patch but it didn't go to linux-media ML by certain
reason. Anyway this is good catch.

Acked-by: Joonyoung Shim <jy0922.s...@samsung.com>

Signed-off-by: Marek Szyprowski<m.szyprow...@samsung.com>
Signed-off-by: Kyungmin Park<kyungmin.p...@samsung.com>
CC: Tobias Lorenz<tobias.lor...@gmx.net>
CC: Joonyoung Shim<jy0922.s...@samsung.com>
CC: Douglas Schilling Landgraf<dougsl...@redhat.com>
CC: Jean Delvare<kh...@linux-fr.org>
---
  drivers/media/radio/si470x/radio-si470x-i2c.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c 
b/drivers/media/radio/si470x/radio-si470x-i2c.c
index 67a4ec8..4ce541a 100644
--- a/drivers/media/radio/si470x/radio-si470x-i2c.c
+++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
@@ -395,7 +395,7 @@ static int __devinit si470x_i2c_probe(struct i2c_client 
*client,
        radio->registers[POWERCFG] = POWERCFG_ENABLE;
        if (si470x_set_register(radio, POWERCFG)<  0) {
                retval = -EIO;
-               goto err_all;
+               goto err_video;
        }
        msleep(110);


--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to