On Wednesday 17 March 2010 15:16:20 Sakari Ailus wrote: > Laurent Pinchart wrote: > >>>> I'm trying to get latest Sakari's tree (gitorious.org/omap3camera) > >>>> 'devel' branch running on my Zoom3 HW (which has an OMAP3630, and a > >>>> Sony IMX046 8MP sensor). > >>>> > >>>> I had first one NULL pointer dereference while the driver was > >>>> registering devices and creating entities, which I resolved with > >>>> the attached patch. (Is this patch acceptable, or maybe I am missing > >>>> something...) > >>> > >>> Either that, or make OMAP34XXCAM_VIDEODEVS dynamic (the value would be > >>> passed through platform data). The code will be removed (hopefully > >>> soon) anyway when the legacy video nodes will disappear. > >> > >> Ok, so should I keep this patch only to myself until this code is > >> removed? > > > > I'll let Sakari answer that, but I think they can still go in in the > > meantime. > > Is there a need for the patch? The other possible device is just left > unused, right?
Without the patch you get an oops because the driver dereferences NULL pointers. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
