On 9/12/19 10:10 PM, Jacopo Mondi wrote:
> Add the 'location' device property, used to specify a device mounting
> position. The property is particularly meaningful for mobile devices
> with a well defined usage orientation.
>
> Signed-off-by: Jacopo Mondi <[email protected]>
> ---
> .../devicetree/bindings/media/video-interfaces.txt | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
> b/Documentation/devicetree/bindings/media/video-interfaces.txt
> index f884ada0bffc..e71b90a29d7a 100644
> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt
> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt
> @@ -89,6 +89,17 @@ Optional properties
> but a number of degrees counter clockwise. Typical values are 0 and 180
> (upside down).
>
> +- location: The device, typically an image sensor or a flash LED, mounting
> + location expressed as a position relative to the usage orientation of the
> + system where the device is installed on.
This sentence is a bit awkward. How about this:
location: The mount location of a device (typically an image sensor or a flash
LED)
expressed as a position relative to the usage orientation of the system where
the
device is installed on.
> + Possible values are:
> + 0 - Front. The device is mounted on the front facing side of the system For
system For -> system. For
Actually, I'd move the For to the next line.
> + mobile devices such as smartphones, tablets and laptops the front side is
> the
> + user facing side.
> + 1 - Back. The device is mounted on the back side of the system, which is
> + defined as the opposite side of the front facing one.
> + 2 - External. The device is not attached directly to the system, or is
I think you mean 'but is' instead of 'or is'.
> + attached in a way that allows it to move freely.
>
> Optional endpoint properties
> ----------------------------
> --
> 2.23.0
>
Regards,
Hans
