Hi Sakari, On Fri, Mar 01, 2019 at 01:23:57PM +0200, Sakari Ailus wrote: > Address a compiler warnings on alignment of struct ipu3_uapi_awb_fr_config_s > by adding __attribute__((aligned(32))) to a struct member of that type as > well. >
Sorry, just noticed there was a v2.
This is how we momentary worked it around in libcamera, so my tag on
v1 also applies here too :)
Could I know why this is preferred compared to v1? Has the field to be
actually 32 bytes aligned?
Thanks
j
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
> Tested-by: Rajmohan Mani <rajmohan.m...@intel.com>
> ---
> drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h
> b/drivers/staging/media/ipu3/include/intel-ipu3.h
> index eb6f52aca9929..4a0e97b0cfd2b 100644
> --- a/drivers/staging/media/ipu3/include/intel-ipu3.h
> +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h
> @@ -2472,7 +2472,7 @@ struct ipu3_uapi_acc_param {
> struct ipu3_uapi_yuvp1_yds_config yds2 __attribute__((aligned(32)));
> struct ipu3_uapi_yuvp2_tcc_static_config tcc
> __attribute__((aligned(32)));
> struct ipu3_uapi_anr_config anr;
> - struct ipu3_uapi_awb_fr_config_s awb_fr;
> + struct ipu3_uapi_awb_fr_config_s awb_fr __attribute__((aligned(32)));
> struct ipu3_uapi_ae_config ae;
> struct ipu3_uapi_af_config_s af;
> struct ipu3_uapi_awb_config awb;
> --
> 2.11.0
>
signature.asc
Description: PGP signature
