Em Wed, 20 Mar 2019 13:33:05 +0100
hverkuil-ci...@xs4all.nl escreveu:

> From: Hans Verkuil <hverkuil-ci...@xs4all.nl>
> 
> The cedrus stateless decoder requires the use of request, so
> indicate this by setting requires_requests to 1.
> 
> Note that the cedrus driver never checked for this, and as far
> as I can tell would just crash if an attempt was made to queue
> a buffer without a request.
> 
> Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
> Acked-by: Paul Kocialkowski <paul.kocialkow...@bootlin.com>
> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c 
> b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index b47854b3bce4..9673874ece10 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -536,6 +536,7 @@ int cedrus_queue_init(void *priv, struct vb2_queue 
> *src_vq,
>       src_vq->lock = &ctx->dev->dev_mutex;
>       src_vq->dev = ctx->dev->dev;
>       src_vq->supports_requests = true;
> +     src_vq->requires_requests = true;

looks OK to my eyes.

>  
>       ret = vb2_queue_init(src_vq);
>       if (ret)



Thanks,
Mauro

Reply via email to