Hi, Sakari, > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Friday, February 1, 2019 2:43 AM > To: Zhi, Yong <yong....@intel.com> > Cc: linux-media@vger.kernel.org; Mani, Rajmohan > <rajmohan.m...@intel.com>; tf...@chromium.org; > laurent.pinch...@ideasonboard.com; hans.verk...@cisco.com; > mche...@kernel.org; dan.carpen...@oracle.com; Qiu, Tian Shu > <tian.shu....@intel.com>; Cao, Bingbu <bingbu....@intel.com> > Subject: Re: [PATCH v2 2/2] media: ipu3-imgu: Remove dead code for NULL > check > > Hi Yong, > > On Wed, Jan 16, 2019 at 09:18:47AM -0800, Yong Zhi wrote: > > Since ipu3_css_buf_dequeue() never returns NULL, remove the dead code > > to fix static checker warning: > > > > drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded() > > warn: 'b' is an error pointer or valid > > > > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> [Bug report: > > https://lore.kernel.org/linux-media/20190104122856.GA1169@kadam/] > > Signed-off-by: Yong Zhi <yong....@intel.com> > > Reviewed-by: Tomasz Figa <tf...@chromium.org> > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > I don't see Laurent's Reviewed-by: tag on the list. Did you get that from him > off-list? If he hasn't given one, please send v3 without that tag. >
The bug report link was suggested by Laurent, so that I assume he reviewed the patch, I can re-send without the tag if this does not count. > Thanks. > > -- > Sakari Ailus > sakari.ai...@linux.intel.com
