Hi Dafna, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.0-rc2 next-20190115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dafna-Hirschfeld/media-vicodec-bugfix-replace-with/20190115-233633 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x011-201902 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): In file included from include/linux/compiler_types.h:68:0, from <command-line>:0: drivers/media/platform/vicodec/vicodec-core.c: In function 'vidioc_try_fmt.isra.0': >> include/linux/compiler-gcc.h:75:45: warning: 'pix' may be used uninitialized >> in this function [-Wmaybe-uninitialized] #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^~~~~~~~~~~~ drivers/media/platform/vicodec/vicodec-core.c:513:26: note: 'pix' was declared here struct v4l2_pix_format *pix; ^~~ -- In file included from include/linux/compiler_types.h:68:0, from <command-line>:0: drivers/media//platform/vicodec/vicodec-core.c: In function 'vidioc_try_fmt.isra.0': >> include/linux/compiler-gcc.h:75:45: warning: 'pix' may be used uninitialized >> in this function [-Wmaybe-uninitialized] #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^~~~~~~~~~~~ drivers/media//platform/vicodec/vicodec-core.c:513:26: note: 'pix' was declared here struct v4l2_pix_format *pix; ^~~ vim +/pix +75 include/linux/compiler-gcc.h 87358710 David Woodhouse 2018-02-19 74 cb984d10 Joe Perches 2015-06-25 @75 #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) cb984d10 Joe Perches 2015-06-25 76 :::::: The code at line 75 was first introduced by commit :::::: cb984d101b30eb7478d32df56a0023e4603cba7f compiler-gcc: integrate the various compiler-gcc[345].h files :::::: TO: Joe Perches <j...@perches.com> :::::: CC: Linus Torvalds <torva...@linux-foundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
