Hi Yong,

On Mon, Oct 29, 2018 at 03:23:06PM -0700, Yong Zhi wrote:
> This patch implements the functions to initialize
> and configure IPU3 h/w such as clock, irq and power.
> 
> Signed-off-by: Yong Zhi <yong....@intel.com>
> Signed-off-by: Tomasz Figa <tf...@chromium.org>
> ---
>  drivers/media/pci/intel/ipu3/ipu3-css.c | 537 
> ++++++++++++++++++++++++++++++++
>  drivers/media/pci/intel/ipu3/ipu3-css.h | 203 ++++++++++++
>  2 files changed, 740 insertions(+)
>  create mode 100644 drivers/media/pci/intel/ipu3/ipu3-css.c
>  create mode 100644 drivers/media/pci/intel/ipu3/ipu3-css.h
> 

...

> diff --git a/drivers/media/pci/intel/ipu3/ipu3-css.h 
> b/drivers/media/pci/intel/ipu3/ipu3-css.h
> new file mode 100644
> index 0000000..d16d0c4
> --- /dev/null
> +++ b/drivers/media/pci/intel/ipu3/ipu3-css.h

...

> +/* IPU3 Camera Sub System structure */
> +struct ipu3_css {
> +     struct device *dev;
> +     void __iomem *base;
> +     const struct firmware *fw;
> +     struct imgu_fw_header *fwp;
> +     int iomem_length;

u32? The same for the length parameter in ccs_init().

-- 
Regards,

Sakari Ailus
sakari.ai...@linux.intel.com

Reply via email to