On Fri, 5 Oct 2018 at 09:49, Hans Verkuil <hverk...@xs4all.nl> wrote:
>
> From: Hans Verkuil <hans.verk...@cisco.com>
>
> Some old Samsung drivers use the legacy crop API incorrectly:
> the crop and compose targets are swapped. Normally VIDIOC_G_CROP
> will return the CROP rectangle of a CAPTURE stream and the COMPOSE
> rectangle of an OUTPUT stream.
>
> The Samsung drivers do the opposite. Note that these drivers predate
> the selection API.
>
> If this 'QUIRK' flag is set, then the v4l2-ioctl core will swap
> the CROP and COMPOSE targets as well.
>
> That way backwards compatibility is ensured and we can convert the
> Samsung drivers to the selection API.
>
> Signed-off-by: Hans Verkuil <hans.verk...@cisco.com>

Reviewed-by: Sylwester Nawrocki <s.nawro...@samsung.com>

Reply via email to