Hi Alan, On Mon, Jun 25, 2018 at 03:29:41PM +0800, alanx.chi...@intel.com wrote: > From: "alanx.chiang" <alanx.chi...@intel.com> > > In at24.c, it uses 8-bit addressing by default. In this patch, > add a property address-width that provides a flexible method to > pass the information to driver so that don't need to add the acpi > or i2c ids for specific module.
Instead I'd point to the fact that other chip features have specific properties while this one does not have one yet. > > alanx.chiang (2): > eeprom: at24: Add support for address-width property > dt-bindings: at24: Add address-width property > > Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++ > drivers/misc/eeprom/at24.c | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) > A few notes: - Please cc patches (or patchsets) touching DT bindings to the devicetree list <devicet...@vger.kernel.org>. - Do also CC the maintainer (use scripts/get_maintainer.pl if unclear). - Linux-media list is not the right list for I²C EEPROM driver patches --- please send the patches to linux-...@vger.kernel.org instead. - You generally need to obtain the reviewed-by (or acked-by) tags from reviewers explicitly. You can't just add them based on people commenting on your patches. - DT binding patches precede driver changes. Please send v2 with these addressed. -- Kind regards, Sakari Ailus sakari.ai...@linux.intel.com
