Hello Mauro!
> This patch looks fine, but not for the above-mentioned.
So I shall reword the commit message?
> The thing is that it is not consistent to have some places with
> things like:
> timeout = ktime_set(1, ir->polling * 1000000);
>
> and others with:
> timeout = ir->polling * 1000000;
With my patch applied I can find ONLY two "ir->polling * 1000000" and both are
used
together with ktime_set.
$ grep -r "ir->polling" *
media/i2c/ir-kbd-i2c.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling_interval));
media/i2c/ir-kbd-i2c.c: ir->polling_interval = DEFAULT_POLLING_INTERVAL;
media/i2c/ir-kbd-i2c.c: ir->polling_interval =
init_data->polling_interval;
media/usb/em28xx/em28xx-input.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling));
media/usb/em28xx/em28xx-input.c: ir->polling = 100; /* ms */
media/usb/em28xx/em28xx-input.c:
schedule_delayed_work(&ir->work, msecs_to_jiffies(ir->polling));
media/usb/tm6000/tm6000-input.c: if (!ir->polling)
media/usb/tm6000/tm6000-input.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling));
media/usb/tm6000/tm6000-input.c: ir->polling = 50;
media/usb/tm6000/tm6000-input.c: if (!ir->polling)
media/usb/au0828/au0828-input.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling));
media/usb/au0828/au0828-input.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling));
media/usb/au0828/au0828-input.c: ir->polling = 100; /* ms */
media/usb/au0828/au0828-input.c: schedule_delayed_work(&ir->work,
msecs_to_jiffies(ir->polling));
media/pci/saa7134/saa7134-input.c: if (ir->polling) {
media/pci/saa7134/saa7134-input.c: if (ir->polling) {
media/pci/saa7134/saa7134-input.c: if (!ir->polling && !ir->raw_decode) {
media/pci/saa7134/saa7134-input.c: mod_timer(&ir->timer, jiffies +
msecs_to_jiffies(ir->polling));
media/pci/saa7134/saa7134-input.c: if (ir->polling) {
media/pci/saa7134/saa7134-input.c: if (ir->polling)
media/pci/saa7134/saa7134-input.c: ir->polling = polling;
media/pci/cx88/cx88-input.c: if (ir->polling) {
media/pci/cx88/cx88-input.c: ir->polling ? "poll" : "irq",
media/pci/cx88/cx88-input.c: ktime_set(0,
ir->polling * 1000000));
media/pci/cx88/cx88-input.c: if (ir->polling) {
media/pci/cx88/cx88-input.c: ktime_set(0, ir->polling
* 1000000),
media/pci/cx88/cx88-input.c: if (ir->polling)
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 1; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 5; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 10; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 1; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 1; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 1; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 50; /* ms */
media/pci/cx88/cx88-input.c: ir->polling = 100; /* ms */
media/pci/bt8xx/bttv-input.c: if (ir->polling) {
media/pci/bt8xx/bttv-input.c: ir->polling ? "poll" :
"irq",
media/pci/bt8xx/bttv-input.c: else if (!ir->polling)
media/pci/bt8xx/bttv-input.c: mod_timer(&ir->timer, jiffies +
msecs_to_jiffies(ir->polling));
media/pci/bt8xx/bttv-input.c: if (ir->polling) {
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; // ms
media/pci/bt8xx/bttv-input.c: ir->polling = 50; /* ms */
media/pci/bt8xx/bttv-input.c: ir->polling = 50; /* ms */
media/pci/bt8xx/bttv-input.c: ir->polling = 1; /* ms */
Currently I am using the exact same patch in media-build. media-build would
not be able to compile without error for all Kernels, if I would have
overlook a setting of ktime_t without ktime_set.
Please point me where I can find the "timeout = ir->polling * 1000000;"
you mentioned.
> My preference is to keep using it, as it makes it better documented.
This is also my preference.
> The fact that it makes maintainership of the media_build backport
> tree easier is just a plus, but it makes no sense upstream.
We fixed all those issues in the past in media-tree. All drivers which
are able (enabled) to be compiled for Kernels older than 4.10 are using
ktime_set.
When you mean we shall change all drivers to use ktime_set (even the ones
which are currently not compiled for <4.10), then I can try to find those
and add it to the patch.
Even the mentioned 8b0e195314fa commit did not fix all existing ktime_set(0, 0):
$ grep -r ktime_set | grep "0, 0"
drivers/scsi/ufs/ufshcd.c: hba->lrb[task_tag].compl_time_stamp =
ktime_set(0, 0);
drivers/scsi/ufs/ufshcd.c: hba->ufs_stats.last_hibern8_exit_tstamp =
ktime_set(0, 0);
drivers/scsi/ufs/ufshcd.c: hba->ufs_stats.last_hibern8_exit_tstamp
= ktime_set(0, 0);
drivers/scsi/ufs/ufshcd.c: hba->ufs_stats.last_hibern8_exit_tstamp =
ktime_set(0, 0);
drivers/ntb/test/ntb_perf.c: pthr->duration = ktime_set(0, 0);
drivers/net/can/usb/peak_usb/pcan_usb_core.c: time_ref->tv_host =
ktime_set(0, 0);
drivers/thermal/thermal_sysfs.c: stats->time_in_state[i] =
ktime_set(0, 0);
drivers/dma-buf/sync_file.c: ktime_set(0, 0);
drivers/staging/greybus/loopback.c: gb->ts = ktime_set(0, 0);
arch/mips/kvm/emulate.c: ktime_t now = ktime_set(0, 0); /* silence bogus
GCC warning */
BR,
Jasmin
