Hi Mauro, I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.17-rc1 next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-radio-allow-building-ISA-drivers-with-COMPILE_TEST/20180422-180508 base: git://linuxtv.org/media_tree.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) >> drivers/media/radio/radio-isa.c:108:16: sparse: expression using sizeof(void) -- >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-sf16fmi.c:123:24: sparse: expression using >> sizeof(void) -- >> drivers/media/radio/radio-sf16fmr2.c:169:25: sparse: expression using >> sizeof(void) drivers/media/radio/radio-sf16fmr2.c:171:24: sparse: expression using sizeof(void) -- >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) >> drivers/media/radio/radio-cadet.c:219:16: sparse: expression using >> sizeof(void) vim +108 drivers/media/radio/radio-isa.c 137c579c Hans Verkuil 2012-02-03 98 137c579c Hans Verkuil 2012-02-03 99 static int radio_isa_s_frequency(struct file *file, void *priv, b530a447 Hans Verkuil 2013-03-19 100 const struct v4l2_frequency *f) 137c579c Hans Verkuil 2012-02-03 101 { 137c579c Hans Verkuil 2012-02-03 102 struct radio_isa_card *isa = video_drvdata(file); b530a447 Hans Verkuil 2013-03-19 103 u32 freq = f->frequency; 137c579c Hans Verkuil 2012-02-03 104 int res; 137c579c Hans Verkuil 2012-02-03 105 137c579c Hans Verkuil 2012-02-03 106 if (f->tuner != 0 || f->type != V4L2_TUNER_RADIO) 137c579c Hans Verkuil 2012-02-03 107 return -EINVAL; b530a447 Hans Verkuil 2013-03-19 @108 freq = clamp(freq, FREQ_LOW, FREQ_HIGH); b530a447 Hans Verkuil 2013-03-19 109 res = isa->drv->ops->s_frequency(isa, freq); 137c579c Hans Verkuil 2012-02-03 110 if (res == 0) b530a447 Hans Verkuil 2013-03-19 111 isa->freq = freq; 137c579c Hans Verkuil 2012-02-03 112 return res; 137c579c Hans Verkuil 2012-02-03 113 } 137c579c Hans Verkuil 2012-02-03 114 :::::: The code at line 108 was first introduced by commit :::::: b530a447bb588fdf43fdf4eb909e4ee1921d47ac [media] v4l2: add const to argument of write-only s_frequency ioctl :::::: TO: Hans Verkuil <hans.verk...@cisco.com> :::::: CC: Mauro Carvalho Chehab <mche...@redhat.com> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
