[RFCv9 PATCH 14/29] v4l2-ctrls: do not clone non-standard controls

[Hans Verkuil]

From: Alexandre Courbot <acour...@chromium.org>

Only standard controls can be successfully cloned: handler_new_ref, used
by v4l2_ctrl_request_clone(), forcibly calls v4l2_ctrl_new_std() which
fails to find custom controls names, and we eventually hit the condition
that name == NULL in v4l2_ctrl_new().

This prevents us from using non-standard controls with requests, but
that is enough for testing purposes.

Signed-off-by: Alexandre Courbot <acour...@chromium.org>
---
 drivers/media/v4l2-core/v4l2-ctrls.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c 
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 62f91c0f1e5f..6cf6b2154462 100644
--- a/drivers/media/v4l2-core/v4l2-ctrls.c
+++ b/drivers/media/v4l2-core/v4l2-ctrls.c
@@ -2876,6 +2876,11 @@ static int v4l2_ctrl_request_clone(struct 
v4l2_ctrl_handler *hdl,
                if (filter && !filter(ctrl))
                        continue;
                err = handler_new_ref(hdl, ctrl, &new_ref, false);
+               if (err) {
+                       printk("%s: handler_new_ref on control %x (%s) returned 
%d\n", __func__, ctrl->id, ctrl->name, err);
+                       err = 0;
+                       continue;
+               }
                if (err)
                        break;
                if (from->req_obj.req)
-- 
2.16.1