Hi Andy, On Fri, Mar 16, 2018 at 12:47 AM, Andy Yeh <andy....@intel.com> wrote: > From: Jason Chen <jasonx.z.c...@intel.com> > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh <andy....@intel.com> > Signed-off-by: Alan Chiang <alanx.chi...@intel.com> > --- > since v2: > -- Update the streaming function to remove SW_STANDBY in the beginning. > -- Adjust the delay time from 1ms to 12ms before set stream-on register. > since v3: > -- fix the sd.entity to make code be compiled on the mainline kernel. > since v4: > -- Enabled AG, DG, and Exposure time control correctly. > since v5: > -- Sensor vendor provided a new setting to fix different CLK issue > -- Add one more resolution for 1048x780, used for VGA streaming > since v6: > -- improved i2c read/write function to support writing 2 registers > -- modified i2c reg read/write function with a more portable way > -- utilized v4l2_find_nearest_size instead of the local find_best_fit function > -- defined an enum for the link freq entries for explicit indexing > since v7: > -- Removed usleep due to sufficient delay implemented in coreboot > -- Added handling for VBLANK control that auto frame-line-control is enabled > since v8: > -- Fix some error return and intents >
Reviewed-by: Tomasz Figa <tf...@chromium.org> Thanks for patiently addressing all the comments! Best regards, Tomasz
