On 06.02.2018 22:22, Hans Verkuil wrote: > On 02/06/2018 10:01 PM, Florian Echtler wrote: >> The SUR40 can recognize specific printed patterns directly in hardware; >> this information (i.e. the pattern id) is present but currently unused >> in the blob structure. >> >> >> __le32 area; /* size in pixels/pressure (?) */ >> >> - u8 padding[32]; >> + u8 padding[24]; >> + >> + __le32 tag_id; /* valid when type == 0x04 (SUR40_TAG) */ >> + __le32 unknown; >> >> } __packed; >> > Usually new fields are added before the padding, not after. > > Unless there is a good reason for this I'd change this.
This is how the hardware sends it, so there's little choice in how to arrange the fields... Best regards, Florian -- SENT FROM MY DEC VT50 TERMINAL
signature.asc
Description: OpenPGP digital signature
