Hello Akinobu, On Mon, Jan 22, 2018 at 12:14:13AM +0900, Akinobu Mita wrote: > This patchset adds device tree probing for ov9650 driver. This contains > an actual driver change and a newly added binding documentation part. > > * Changelog v3 > - Add Reviewed-by: tags > - Add MAINTAINERS entry > > * Changelog v2 > - Split binding documentation, suggested by Rob Herring and Jacopo Mondi > - Improve the wording for compatible property in the binding documentation, > suggested by Jacopo Mondi > - Improve the description for the device node in the binding documentation, > suggested by Sakari Ailus > - Remove ov965x_gpio_set() helper and open-code it, suggested by Jacopo Mondi > and Sakari Ailus > - Call clk_prepare_enable() in s_power callback instead of probe, suggested > by Sakari Ailus > - Unify clk and gpio configuration in a single if-else block and, also add > a check either platform data or fwnode is actually specified, suggested > by Jacopo Mondi > - Add CONFIG_OF guards, suggested by Jacopo Mondi > > Akinobu Mita (3): > media: ov9650: support device tree probing > media: MAINTAINERS: add entry for ov9650 driver > media: ov9650: add device tree binding
As you've closed my comments on v1/v2, for driver and device tree bindings: Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> No need to resend just to add the tags, but in case you have to, please add them. Thanks j > > .../devicetree/bindings/media/i2c/ov9650.txt | 36 ++++++ > MAINTAINERS | 10 ++ > drivers/media/i2c/ov9650.c | 130 > +++++++++++++++------ > 3 files changed, 138 insertions(+), 38 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov9650.txt > > Cc: Sylwester Nawrocki <s.nawro...@samsung.com> > Cc: Jacopo Mondi <jac...@jmondi.org> > Cc: H. Nikolaus Schaller <h...@goldelico.com> > Cc: Hugues Fruchet <hugues.fruc...@st.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho Chehab <mche...@s-opensource.com> > Cc: Rob Herring <r...@kernel.org> > -- > 2.7.4 >
