Hi Sakari, > -----Original Message----- > From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com] > Sent: Tuesday, November 21, 2017 9:22 AM > To: Mani, Rajmohan <rajmohan.m...@intel.com> > Cc: Sakari Ailus <sakari.ai...@iki.fi>; Zhi, Yong <yong....@intel.com>; linux- > me...@vger.kernel.org; Zheng, Jian Xu <jian.xu.zh...@intel.com>; Toivonen, > Tuukka <tuukka.toivo...@intel.com>; Hu, Jerry W <jerry.w...@intel.com> > Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions > > Hi Rajmohan, > > My apologies for the late reply. > > On Sat, Nov 11, 2017 at 04:07:22AM +0000, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > -----Original Message----- > > > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > > > Sent: Friday, October 20, 2017 2:30 AM > > > To: Zhi, Yong <yong....@intel.com> > > > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > > > Zheng, Jian Xu <jian.xu.zh...@intel.com>; Mani, Rajmohan > > > <rajmohan.m...@intel.com>; Toivonen, Tuukka > > > <tuukka.toivo...@intel.com>; Hu, Jerry W <jerry.w...@intel.com> > > > Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI > > > definitions > > > > > > Hi Yong, > > > > > > On Tue, Oct 17, 2017 at 10:54:49PM -0500, Yong Zhi wrote: > > ... > > > > > +struct ipu3_uapi_params { > > > > + __u32 fourcc; /* V4L2_PIX_FMT_IPU3_PARAMS */ > > > > + __u32 version; /* Must be 0x100 */ > > > > > > These were called padding1 and padding2 in the previous version. > > > What happened? > > > > > > I'd just call them reserved, and maybe also make the use field the > > > first member of the struct. > > > > > > > These fields were repurposed after v3 of this patch series. Please see the > > user > space code that uses these fields. > > https://chromium.googlesource.com/chromiumos/platform/arc- > camera/+/mas > > ter/hal/intel/psl/ipu3/workers/IPU3AicToFwEncoder.cpp > > They were fourcc and version in the beginning, and then replaced by > padding1 and padding 2. Is there a particular reason for changing them back? >
We looked into this further to see that we have no compelling reasons to use these variables. I will revert these names back to padding1 and padding2, along with the required user space code changes.
