kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/media/pci/cx23885/cx23885-input.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/cx23885/cx23885-input.c 
b/drivers/media/pci/cx23885/cx23885-input.c
index 944b7083..0f4e542 100644
--- a/drivers/media/pci/cx23885/cx23885-input.c
+++ b/drivers/media/pci/cx23885/cx23885-input.c
@@ -340,14 +340,23 @@ int cx23885_input_init(struct cx23885_dev *dev)
        kernel_ir->cx = dev;
        kernel_ir->name = kasprintf(GFP_KERNEL, "cx23885 IR (%s)",
                                    cx23885_boards[dev->board].name);
+       if (!kernel_ir->name) {
+               ret = -ENOMEM;
+               goto err_out_free;
+       }
+
        kernel_ir->phys = kasprintf(GFP_KERNEL, "pci-%s/ir0",
                                    pci_name(dev->pci));
+       if (!kernel_ir->phys) {
+               ret = -ENOMEM;
+               goto err_out_free_name;
+       }
 
        /* input device */
        rc = rc_allocate_device(RC_DRIVER_IR_RAW);
        if (!rc) {
                ret = -ENOMEM;
-               goto err_out_free;
+               goto err_out_free_phys;
        }
 
        kernel_ir->rc = rc;
@@ -382,9 +391,11 @@ int cx23885_input_init(struct cx23885_dev *dev)
        cx23885_input_ir_stop(dev);
        dev->kernel_ir = NULL;
        rc_free_device(rc);
-err_out_free:
+err_out_free_phys:
        kfree(kernel_ir->phys);
+err_out_free_name:
        kfree(kernel_ir->name);
+err_out_free:
        kfree(kernel_ir);
        return ret;
 }
-- 
1.9.1

Reply via email to