On Fri, Jul 14, 2017 at 10:58:39AM +0200, Javier Martinez Canillas wrote:
> The vimc platform drivers define a platform device ID table but these
> are not set to the .id_table field in the platform driver structure.
>
> So the platform device ID table is only used to fill the aliases in
> the module but are not used for matching (works because the platform
> subsystem fallbacks to the driver's name if no .id_table is set).
>
> But this also means that the platform device ID table isn't used if
> the driver is built-in, which leads to the following build warning:
>
> This causes the following build warnings when the driver is built-in:
>
> drivers/media/platform/vimc//vimc-capture.c:528:40: warning:
> ‘vimc_cap_driver_ids’ defined but not used [-Wunused-const-variable=]
> static const struct platform_device_id vimc_cap_driver_ids[] = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/media/platform/vimc//vimc-debayer.c:588:40: warning:
> ‘vimc_deb_driver_ids’ defined but not used [-Wunused-const-variable=]
> static const struct platform_device_id vimc_deb_driver_ids[] = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/media/platform/vimc//vimc-scaler.c:442:40: warning:
> ‘vimc_sca_driver_ids’ defined but not used [-Wunused-const-variable=]
> static const struct platform_device_id vimc_sca_driver_ids[] = {
> ^~~~~~~~~~~~~~~~~~~
> drivers/media/platform/vimc//vimc-sensor.c:376:40: warning:
> ‘vimc_sen_driver_ids’ defined but not used [-Wunused-const-variable=]
> static const struct platform_device_id vimc_sen_driver_ids[] = {
> ^~~~~~~~~~~~~~~~~~~
>
> Reported-by: Mauro Carvalho Chehab <mche...@s-opensource.com>
> Suggested-by: Sakari Ailus <sakari.ai...@iki.fi>
> Signed-off-by: Javier Martinez Canillas <javi...@redhat.com>
Thanks!
Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk
