Hi Yong, On Wed, Jun 14, 2017 at 5:17 AM, Yong Zhi <yong....@intel.com> wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > Signed-off-by: Yong Zhi <yong....@intel.com> > --- > drivers/media/pci/Kconfig | 2 + > drivers/media/pci/Makefile | 3 +- > drivers/media/pci/intel/Makefile | 5 + > drivers/media/pci/intel/ipu3/Kconfig | 17 + > drivers/media/pci/intel/ipu3/Makefile | 1 + > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1779 > ++++++++++++++++++++++++++++++ > drivers/media/pci/intel/ipu3/ipu3-cio2.h | 434 ++++++++ > 7 files changed, 2240 insertions(+), 1 deletion(-) > create mode 100644 drivers/media/pci/intel/Makefile > create mode 100644 drivers/media/pci/intel/ipu3/Kconfig > create mode 100644 drivers/media/pci/intel/ipu3/Makefile > create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.c > create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.h >
I quickly checked the code and it doesn't seem to have most of my comments from v2 addressed. It's not a very good practice to send new version without addressing or at least replying to all the comments - it's the best way to lose track of necessary changes. Please make sure that all the comments are taken care of. Best regards, Tomasz
