If the probe fails (e.g. port already in use), rmmod causes null deref.

Signed-off-by: Sean Young <s...@mess.org>
---
 drivers/media/rc/sir_ir.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/rc/sir_ir.c b/drivers/media/rc/sir_ir.c
index 90a5f8f..c27d6b4 100644
--- a/drivers/media/rc/sir_ir.c
+++ b/drivers/media/rc/sir_ir.c
@@ -381,6 +381,8 @@ static int sir_ir_probe(struct platform_device *dev)
 
 static int sir_ir_remove(struct platform_device *dev)
 {
+       drop_hardware();
+       drop_port();
        return 0;
 }
 
@@ -421,8 +423,6 @@ static int __init sir_ir_init(void)
 
 static void __exit sir_ir_exit(void)
 {
-       drop_hardware();
-       drop_port();
        platform_device_unregister(sir_ir_dev);
        platform_driver_unregister(&sir_ir_driver);
 }
-- 
2.9.4

Reply via email to