Re: [PATCH] omap3isp: add support for CSI1 bus

[Pavel Machek]

Hi!

> > +           if (enable) {
> > +                   csirxfe = OMAP343X_CONTROL_CSIRXFE_PWRDNZ |
> > +                             OMAP343X_CONTROL_CSIRXFE_RESET;
> > +
> > +                   if (buscfg->phy_layer)
> > +                           csirxfe |= OMAP343X_CONTROL_CSIRXFE_SELFORM;
> > +
> > +                   if (buscfg->strobe_clk_pol)
> > +                           csirxfe |= OMAP343X_CONTROL_CSIRXFE_CSIB_INV;
> > +           } else
> > +                   csirxfe = 0;
> 
> You need curly braces for the else statement too.
> 
> > +
> > +           regmap_write(isp->syscon, isp->syscon_offset, csirxfe);
> 
> Isn't this already configured by csiphy_routing_cfg_3430(), called through 
> omap3isp_csiphy_acquire() ? You'll need to add support for the strobe/clock 
> polarity there, but the rest should already be handled.

It seems csiphy_routing_cfg_3430 is not called at all. I added
printks, but they don't trigger. If you have an idea what is going on
there, it would help...
                                                                        Pavel

diff --git a/drivers/media/platform/omap3isp/ispcsiphy.c 
b/drivers/media/platform/omap3isp/ispcsiphy.c
index 6b814e1..fe9303a 100644
--- a/drivers/media/platform/omap3isp/ispcsiphy.c
+++ b/drivers/media/platform/omap3isp/ispcsiphy.c
@@ -30,6 +30,8 @@ static void csiphy_routing_cfg_3630(struct isp_csiphy *phy,
        u32 reg;
        u32 shift, mode;
 
+       printk("routing cfg 3630: iface %d, %d\n", iface, 
ISP_INTERFACE_CCP2B_PHY1);
+       
        regmap_read(phy->isp->syscon, phy->isp->syscon_offset, &reg);
 
        switch (iface) {
@@ -74,6 +76,9 @@ static void csiphy_routing_cfg_3430(struct isp_csiphy *phy, 
u32 iface, bool on,
        u32 csirxfe = OMAP343X_CONTROL_CSIRXFE_PWRDNZ
                | OMAP343X_CONTROL_CSIRXFE_RESET;
 
+       /* FIXME: can this be used instead of if (isp->revision) in ispccp2.c? 
*/
+       
+       printk("routing cfg: iface %d, %d\n", iface, ISP_INTERFACE_CCP2B_PHY1);
        /* Only the CCP2B on PHY1 is configurable. */
        if (iface != ISP_INTERFACE_CCP2B_PHY1)
                return;
@@ -105,6 +110,7 @@ static void csiphy_routing_cfg(struct isp_csiphy *phy,
                               enum isp_interface_type iface, bool on,
                               bool ccp2_strobe)
 {
+       printk("csiphy_routing_cfg\n");
        if (phy->isp->phy_type == ISP_PHY_TYPE_3630 && on)
                return csiphy_routing_cfg_3630(phy, iface, ccp2_strobe);
        if (phy->isp->phy_type == ISP_PHY_TYPE_3430)



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

signature.asc
Description: Digital signature