The comments I made before about start_streaming and the use of struct 
venus_ctrl
apply here as well and I won't repeat them.

On 11/07/2016 06:33 PM, Stanimir Varbanov wrote:
> This adds encoder part of the driver plus encoder controls.
> 
> Signed-off-by: Stanimir Varbanov <stanimir.varba...@linaro.org>
> ---
>  drivers/media/platform/qcom/venus/venc.c       | 1212 
> ++++++++++++++++++++++++
>  drivers/media/platform/qcom/venus/venc.h       |   32 +
>  drivers/media/platform/qcom/venus/venc_ctrls.c |  396 ++++++++
>  3 files changed, 1640 insertions(+)
>  create mode 100644 drivers/media/platform/qcom/venus/venc.c
>  create mode 100644 drivers/media/platform/qcom/venus/venc.h
>  create mode 100644 drivers/media/platform/qcom/venus/venc_ctrls.c
> 
> diff --git a/drivers/media/platform/qcom/venus/venc.c 
> b/drivers/media/platform/qcom/venus/venc.c
> new file mode 100644
> index 000000000000..35572eaffb9e
> --- /dev/null
> +++ b/drivers/media/platform/qcom/venus/venc.c

<snip>

> +static int
> +venc_s_selection(struct file *file, void *fh, struct v4l2_selection *s)
> +{
> +     struct venus_inst *inst = to_inst(file);
> +
> +     if (s->type != V4L2_BUF_TYPE_VIDEO_OUTPUT)
> +             return -EINVAL;
> +
> +     switch (s->target) {
> +     case V4L2_SEL_TGT_CROP:
> +             if (s->r.width != inst->out_width ||
> +                 s->r.height != inst->out_height ||
> +                 s->r.top != 0 || s->r.left != 0)
> +                     return -EINVAL;
> +             break;
> +     default:
> +             return -EINVAL;
> +     }
> +
> +     return 0;
> +}

Why implement s_selection if I can't change the selection?

> +
> +static int
> +venc_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *b)
> +{
> +     struct vb2_queue *queue = to_vb2q(file, b->type);
> +
> +     if (!queue)
> +             return -EINVAL;
> +
> +     return vb2_reqbufs(queue, b);
> +}

Use the m2m helpers if at all possible.

Regards,

        Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to