I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> Signed-off-by: Baole Ni <baolex...@intel.com> --- drivers/media/pci/bt8xx/bttv-vbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/bt8xx/bttv-vbi.c b/drivers/media/pci/bt8xx/bttv-vbi.c index e77129c..af2ce4a 100644 --- a/drivers/media/pci/bt8xx/bttv-vbi.c +++ b/drivers/media/pci/bt8xx/bttv-vbi.c @@ -59,8 +59,8 @@ static unsigned int vbibufs = 4; static unsigned int vbi_debug; -module_param(vbibufs, int, 0444); -module_param(vbi_debug, int, 0644); +module_param(vbibufs, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(vbi_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(vbibufs,"number of vbi buffers, range 2-32, default 4"); MODULE_PARM_DESC(vbi_debug,"vbi code debug messages, default is 0 (no)"); -- 2.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
